UniFFI don't panic on failed lift #373
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
==========================================
- Coverage 74.19% 74.04% -0.16%
==========================================
Files 253 254 +1
Lines 21897 21918 +21
==========================================
- Hits 16247 16229 -18
- Misses 5650 5689 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
addisonbeck
previously approved these changes
Aug 1, 2025
Thomas-Avery
previously approved these changes
Aug 1, 2025
Co-authored-by: Thomas Avery <[email protected]>
dani-garcia
dismissed stale reviews from Thomas-Avery and addisonbeck
via
83f3537
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
UniFFI uses the
custom_type!macro to convert request/response types. The request conversion is allowed to fail which should produce an error in the apps, but there are cases where it would produce a panic instead. The cases are:custom_type!, then UniFFI produces a panic.One way to fix this is to have the
custom_type!calls returnbitwarden_uniffi::error::BitwardenError, but this isn't possible as core and crypto can't depend on uniffi due to circular dependency issues.This PR makes the uniffi crate register an error conversion function during client initialization, thanks to the use of a new
uniffi-errorcrate. It also updates all the calls tocustom_type!to use this new error conversion.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes